-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove "[COPY]" from unarchived test + no draft archival #608
base: staging
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 7a94a7e): https://jump-math-staging--pr608-julian-test-archivin-4mqs1ivm.web.app (expires Thu, 09 Nov 2023 03:36:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51 |
{assessmentStatus === Status.PUBLISHED && ( | ||
<> | ||
<ArchiveButton assessmentId={assessmentId} /> | ||
<Divider /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have both <Divider />
here and in line 24? Does it not work for nested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Notion ticket link
Fix logic around test archiving
Implementation description
[NOTE: this has to get rebased on Joyce's PR before it will work properly.]
Two things:
Steps to test
What should reviewers focus on?
Checklist