Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "[COPY]" from unarchived test + no draft archival #608

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

jfdoming
Copy link
Contributor

Notion ticket link

Fix logic around test archiving

Implementation description

[NOTE: this has to get rebased on Joyce's PR before it will work properly.]

Two things:

  • Don't append "[COPY]" to the name of unarchived tests
  • Remove the ability to archive drafts, since that doesn't make any sense (as discussed on Slack)

Steps to test

  1. Unarchive a test and verify the name is unchanged.
  2. Find a draft assessment in the table and verify there is no "archive" option.
  3. Open a draft assessment for editing and verify there is no "archive" option.

What should reviewers focus on?

  • Any cases I missed?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jfdoming jfdoming temporarily deployed to staging October 29, 2023 21:35 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 29, 2023

Visit the preview URL for this PR (updated for commit 7a94a7e):

https://jump-math-staging--pr608-julian-test-archivin-4mqs1ivm.web.app

(expires Thu, 09 Nov 2023 03:36:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

@jfdoming jfdoming temporarily deployed to staging November 2, 2023 03:34 — with GitHub Actions Inactive
@jfdoming jfdoming marked this pull request as ready for review November 2, 2023 03:34
{assessmentStatus === Status.PUBLISHED && (
<>
<ArchiveButton assessmentId={assessmentId} />
<Divider />
Copy link
Collaborator

@carissa-tang carissa-tang Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have both <Divider /> here and in line 24? Does it not work for nested?

Copy link
Collaborator

@carissa-tang carissa-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants