-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node-fetch to v3.1.1 #104
Comments
On closer inspection. The type errors stated in CI are not the only errors. node-fetch from v3 is an ESM-only module - we cannot import it with require(). I'm running into some weird behaviour locally after doing the migration:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User Story and Context
We have a dependabot PR that upgrades node-fetch to v3.1.1 which needs to be merged. The catch is that this is a major version upgrade that introduces breaking changes. In particular, the typing of the
.json()
method on HTTP responses has changed fromPromise<any>
toPromise<unknown>
and this is incompatible with our current usage inbackend/utilities/firebaseRestClient.ts
. Please resolve these issues and then merge the PR.Acceptance Criteria
backend/utilities/firebaseRestClient.ts
resulting from the node-fetch upgradeDev Notes
The text was updated successfully, but these errors were encountered: