Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate node-fetch to axios #110

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

MatoPlus
Copy link
Member

Ticket link

Closes #104

Implementation description

  • Deprecate node-fetch usage in favor of axios
  • Refactored existing usage of node-fetch
  • Removed node-fetch package and type

Steps to test

  1. Can still log in into app as required

What should reviewers focus on?

  • Usage of axios lie in guideline standards

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade node-fetch to v3.1.1
2 participants