Add tag styling to theme #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LenaNguyen
requested review from
sherryhli,
briantu,
MatoPlus,
krystaltruong and
sohak22
|
Visit the preview URL for this PR (updated for commit 89a2989): https://sistering-dev--pr133-lena-default-tags-1xv108ls.web.app (expires Sun, 13 Feb 2022 22:21:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
MatoPlus
approved these changes
Feb 7, 2022
sherryhli
approved these changes
Feb 7, 2022
briantu
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Add brand colors to theme * add default tag styles * lint and move tags
briantu
added a commit
that referenced
this pull request
Feb 13, 2022
* setup create posting review page * add Open Sans font * create basic information section * remove Open Sans font * finish ui page * Use posting context and fix text styling * Refactor components to common folder * Add tag styling to theme (#133) * Add brand colors to theme * add default tag styles * lint and move tags * Update font uses, add tag variant, and refactor ScheduledShiftsTr * Use normal Tag and remove SkillTag * Change BasicInfoGridItem component to LabelledText * Add posting review details constant to Copy.ts Co-authored-by: Lena Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket link
Closes #132
Implementation description
Implementation:
Designs:
Checklist