Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create volunteer shift row #202

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Create volunteer shift row #202

merged 3 commits into from
Mar 18, 2022

Conversation

LenaNguyen
Copy link
Member

Ticket link

Closes #170

Implementation description

  • Created a volunteer shift row that displays the role title, date time of the shift, and notes

Steps to test

  1. Got to the homepage and check that the volunteer shift row matches the designs. The width is 100% because it will take up the width of the side panel container once that's implemented.
    image

What should reviewers focus on?

  • Implementation matches Figma

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

LenaNguyen
LenaNguyen commented Mar 9, 2022
View reviewed changes
frontend/src/components/pages/Default.tsx Outdated
startDateTime={new Date("2022-04-06T13:30")}
endDateTime={new Date("2022-04-06T15:30")}
notes="I am not available after 2pm"
/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for demo purposes. will be removed

@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 9c8c223):

https://sistering-dev--pr202-lena-volunteer-shift-0u6g4v7v.web.app

(expires Fri, 25 Mar 2022 00:04:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

sherryhli
sherryhli previously approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚢 it!

@LenaNguyen LenaNguyen requested a review from sherryhli March 18, 2022 00:01
@LenaNguyen LenaNguyen merged commit da88911 into main Mar 18, 2022
@LenaNguyen LenaNguyen deleted the lena/volunteer-shift-row branch March 18, 2022 00:29
LenaNguyen added a commit that referenced this pull request Mar 24, 2022
@LenaNguyen
Create volunteer shift row (#202)
18aff88 
* volunter shift row

* use theme border color

* remove demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryhli sherryhli sherryhli approved these changes

@hujoseph99 hujoseph99 Awaiting requested review from hujoseph99

@Boyazhang1 Boyazhang1 Awaiting requested review from Boyazhang1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Volunteer profile shift row
2 participants
@LenaNguyen @sherryhli