Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prisma env file path to secret.config #37

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

sherryhli
Copy link
Member

@sherryhli sherryhli commented Oct 23, 2021

Ticket link

N/A

Implementation description

  • Added Prisma env file path to secret.config

Steps to test

  1. If you have an existing backend/prisma/.env file, delete it
  2. Run the Vault secret update script and check that you have a backend/prisma/.env file and that it is populated with the expected DATABASE_URL
vault kv get -format=json kv/sistering | python update_secret_files.py

What should reviewers focus on?

  • N/A

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@7tint 7tint self-requested a review October 23, 2021 22:05
@sherryhli sherryhli merged commit ed61aae into main Oct 23, 2021
@sherryhli sherryhli deleted the sherry/update-secret-config branch October 23, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants