Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create prisma models for the remaining entities #38

Merged
merged 7 commits into from
Oct 23, 2021
Merged

Create prisma models for the remaining entities #38

merged 7 commits into from
Oct 23, 2021

Conversation

jiarucao
Copy link
Contributor

Ticket link

Closes #16

Implementation description

  • Generated prisma schemas for remaining models

Steps to test

  1. Verify that db tables are created after running migration

What should reviewers focus on?

  • Correct prisma model schemas

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

albertlai431
albertlai431 reviewed Oct 23, 2021
View reviewed changes
albertlai431
albertlai431 requested changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@albertlai431 albertlai431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the types.ts file

@jiarucao jiarucao requested a review from albertlai431 October 23, 2021 23:28
albertlai431
albertlai431 approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@albertlai431 albertlai431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@jiarucao jiarucao merged commit 0a9c9a6 into main Oct 23, 2021
@jiarucao jiarucao deleted the jiaru-albert/create-prisma-models branch October 23, 2021 23:46
sherryhli pushed a commit that referenced this pull request Jan 6, 2022
@jiarucao @albertlai431
Create prisma models for the remaining entities (#38)
0c9612f 
* Create prisma models

* Format the prisma schema

* Create prisma models

* conflict

* Remove errors and update references to user role

* Generate migration files and reverted user entity changes

* Revert trivial backend/types.ts change

Co-authored-by: Albert Lai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertlai431 albertlai431 albertlai431 approved these changes

@sherryhli sherryhli Awaiting requested review from sherryhli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Prisma models for all tables
2 participants
@jiarucao @albertlai431