Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor admin create posting pages into single page component #496

Merged
merged 5 commits into from
Jul 16, 2022

Conversation

7tint
Copy link
Member

@7tint 7tint commented Jul 15, 2022

Ticket link

Closes #213

Implementation description

  • Combined steps of the admin create posting process into a single page component
    • Instead of the three steps (basic info, shifts, review) having different URLs, all steps are now at http://localhost:3000/admin/posting/create
  • Fixed an incorrect query I noticed on the basic info page

Steps to test

  1. Navigate to http://localhost:3000/admin/posting/create and try creating a posting. This should still work as before.

What should reviewers focus on?

  • Didn't break anything 😓

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@7tint
Copy link
Member Author

7tint commented Jul 15, 2022

@MatoPlus I left the three pages (CreatePostingBasicInfoPage, CreatePostingShiftsPage, CreatePostingReviewPage) where they were in src/components/pages/admin/posting.

But they are technically not "pages" with individual routes anymore (since they all live under the new CreatePostingPage).

Let me know if you want this moved elsewhere.

@github-actions
Copy link

github-actions bot commented Jul 15, 2022

Visit the preview URL for this PR (updated for commit 1151e8e):

https://sistering-dev--pr496-refactor-admin-posti-a4byk68d.web.app

(expires Sat, 23 Jul 2022 18:25:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

neelismail01
neelismail01 previously approved these changes Jul 16, 2022
Copy link
Contributor

@neelismail01 neelismail01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is still working on my end 😁

Feel free to merge when you get a chance.

Lambert Liu added 4 commits July 16, 2022 14:15
Refactor AccountForm

Create account edit form

Include admins in employees table seed

Create account edit form

Update EditAccountPage.tsx
@7tint 7tint force-pushed the refactor-admin-posting-pages branch from 702f938 to 056fb31 Compare July 16, 2022 18:20
@7tint 7tint requested a review from neelismail01 July 16, 2022 18:20
@7tint 7tint merged commit 05e91e4 into main Jul 16, 2022
@7tint 7tint deleted the refactor-admin-posting-pages branch July 16, 2022 18:28
@7tint 7tint linked an issue Jul 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor admin create posting flow into one page component
2 participants