capture and log more detail when email recipients aren't defined

uwcirg · Mar 6, 2024 · f1f9e9b · f1f9e9b
1 parent 13926c4
commit f1f9e9b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/portal/models/message.py b/portal/models/message.py
@@ -157,6 +157,10 @@ def send_message(self, cc_address=None):
         NB the cc isn't persisted with the rest of the record.
 
         """
+        if not self.recipients:
+            current_app.logger.error(
+                "can't email w/o recipients.  failed to send "
+                f"'{self.subject}' to user {self.recipient_id}")
         message = Message(
             subject=self.subject,
             extra_headers=extra_headers(),

diff --git a/portal/trigger_states/empro_messages.py b/portal/trigger_states/empro_messages.py
@@ -37,6 +37,7 @@ def patient_email(patient, soft_triggers, hard_triggers):
     mr = MailResource(
         app_text(name), locale_code=patient.locale_code, variables=args)
     em = EmailMessage(
+        recipient_id=patient.id,
         recipients=patient.email,
         sender=current_app.config['MAIL_DEFAULT_SENDER'],
         subject=mr.subject,
@@ -120,6 +121,7 @@ def staff_emails(patient, hard_triggers, initial_notification):
             locale_code=staff.locale_code,
             variables=args)
         emails.append(EmailMessage(
+            recipient_id=staff.id,
             recipients=staff.email,
             sender=current_app.config['MAIL_DEFAULT_SENDER'],
             subject=mr.subject,