user consent withdrawal date regression #4361
Conversation
|
Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-03-05 23:23:17 UTC |
… for better reuse.
… order - the user of `acceptance_date` assumed the newest date would always be best - that's false logic.
… order - the user of `acceptance_date` assumed the newest date would always be best - that's false logic.
…ents, when looking for consent date after user's consent has been suspended (withdrawn)
…r consent deletion resulted in change
…s completed prior to withdrawal - was reporting status "withdrawn"
… `any_change_noted` check
…s "completion-date"
…e rebuilds for affected patients
pbugni
force-pushed
the
feature/user_consent_withdrawal_date_regression
branch
from
5f201e7 to
bef7625
Compare
Adherence report changes: - always include a row for withdrawal, and use 'completed date' column for date of withdrawal - include completed visits even if they are completed after date of withdrawal qb_timeline changes: - include rows after withdrawal for implementation of the above migration changes: - now that we must rebuild the timeline and adherence data for every withdrawn user, it takes far too long to run and would render the service unavailable until the migration completes. therefore, it only removes the timelines and adherence data for that set of users, and will rebuild when first requested. NB: this PR merges into another branch, such that all may be a single update on the develop branch. --------- Co-authored-by: Justin McReynolds <[email protected]> Co-authored-by: Ivan Cvitkovic <[email protected]>
|
@ivan-c , the bulk of the work here you've already seen in the two additional branches that were cut deeper off of this one. a review here is primarily a rubber stamp. |
reverts bug introduced by #4343 , which incorrectly started using the oldest (not most recent) user_consent as last valid consent prior to withdrawal.
includes migration to clean up problem cases. required careful re-assessment of consent/withdrawal dates for a number of patients found to have qb_timeline revisions after applying patch above. see https://movember.atlassian.net/browse/IRONN-210 for more detail.
NB: #4363 merges into this branch, to be done prior to merging this PR.