Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WASM on oneTBB #1006

Merged
merged 15 commits into from
Aug 11, 2023
Merged

Enable WASM on oneTBB #1006

merged 15 commits into from
Aug 11, 2023

Conversation

JhaShweta1
Copy link
Contributor

@JhaShweta1 JhaShweta1 commented Jan 11, 2023

Description

Support oneTBB on WASM

Fixes # - issue number(s) if exists

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

There are a number of tests that are failing due to artifacts of testing. A number of these failed tests need extra flags, which are added in the cmake. Tests for which flags which could not be added are disabled.

collaborative_call_once :-s ALLOW_MEMORY_GROWTH=1 (it was -s TOTAL_MEMORY=128MB)
parallel_invoke: --preload-file /proc/self/status (required only for tests)
task_scheduler_handle: Hardware dependent section sigwait and waitpid fails. – removing them in tests works
task_group :Test_task_group: --preload-file /proc/self/status (required only for tests)
task_group_status: Test_task_group: --preload-file /proc/self/status (required only for tests)
task_handle
Test_task_group, test_task_arena (test that cover this passes): Conditional pass
task_arena
test_task_arena.cpp: Test for task arena entry consistency: FPU control state has not been set correctly
this_task_arena (works)
test_task_arena.cpp: Test for task arena entry consistency: FPU control state has not been set correctly
task_scheduler_observer (works)
test_task_arena.cpp: Test for task arena entry consistency: FPU control state has not been set correctly

We were only interested in the list of APIs that work for emscripten and therefore we have not yet investigated failure of malloc tests. The malloc tests are disabled if they are failing.

@memsharded
Copy link

Hi @JhaShweta1

We got this PR to ConanCenter, applying this patch to 2021.9.0: conan-io/conan-center-index#17777

I see in the patch you are from intel, it would be great to know if this is something that is expected to eventually land and be merged, if there are any potential risks, it seems that it has been there since January without further reviews. Any hint would be very appreciated, many thanks!

@omalyshe
Copy link
Contributor

omalyshe commented Jun 9, 2023

@memsharded Thanks for your interest to this patch. WASM support is work in progress on our side. From the code change you can see, that currently not all TBB tests will be working.
We welcome any feedback and/or contributions to bring it to mergeable quality.

test/CMakeLists.txt Outdated Show resolved Hide resolved
@JhaShweta1
Copy link
Contributor Author

Closed unintentionally

@JhaShweta1 JhaShweta1 reopened this Jul 25, 2023
cmake/compilers/Clang.cmake Outdated Show resolved Hide resolved
cmake/compilers/Clang.cmake Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@JhaShweta1 JhaShweta1 changed the title emscripten Enable WASM on oneTBB Jul 28, 2023
cmake/compilers/Clang.cmake Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/compilers/Clang.cmake Show resolved Hide resolved
cmake/compilers/Clang.cmake Outdated Show resolved Hide resolved
cmake/compilers/Clang.cmake Outdated Show resolved Hide resolved
cmake/compilers/Clang.cmake Show resolved Hide resolved
cmake/compilers/Clang.cmake Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
test/tbb/test_parallel_invoke.cpp Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@JhaShweta1 JhaShweta1 merged commit 7cee225 into master Aug 11, 2023
@JhaShweta1 JhaShweta1 deleted the tbb_wasm branch August 11, 2023 16:34
@omalyshe omalyshe mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants