-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable WASM on oneTBB #1006
Enable WASM on oneTBB #1006
Conversation
Hi @JhaShweta1 We got this PR to ConanCenter, applying this patch to 2021.9.0: conan-io/conan-center-index#17777 I see in the patch you are from intel, it would be great to know if this is something that is expected to eventually land and be merged, if there are any potential risks, it seems that it has been there since January without further reviews. Any hint would be very appreciated, many thanks! |
@memsharded Thanks for your interest to this patch. WASM support is work in progress on our side. From the code change you can see, that currently not all TBB tests will be working. |
Closed unintentionally |
…o exactly one '0' or '1' value
Co-authored-by: Ilya Isaev <[email protected]>
Co-authored-by: Ilya Isaev <[email protected]>
Co-authored-by: Pavel Kumbrasev <[email protected]>
Description
Support oneTBB on WASM
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information
There are a number of tests that are failing due to artifacts of testing. A number of these failed tests need extra flags, which are added in the cmake. Tests for which flags which could not be added are disabled.
collaborative_call_once :-s ALLOW_MEMORY_GROWTH=1 (it was -s TOTAL_MEMORY=128MB)
parallel_invoke: --preload-file /proc/self/status (required only for tests)
task_scheduler_handle: Hardware dependent section sigwait and waitpid fails. – removing them in tests works
task_group :Test_task_group: --preload-file /proc/self/status (required only for tests)
task_group_status: Test_task_group: --preload-file /proc/self/status (required only for tests)
task_handle
Test_task_group, test_task_arena (test that cover this passes): Conditional pass
task_arena
test_task_arena.cpp: Test for task arena entry consistency: FPU control state has not been set correctly
this_task_arena (works)
test_task_arena.cpp: Test for task arena entry consistency: FPU control state has not been set correctly
task_scheduler_observer (works)
test_task_arena.cpp: Test for task arena entry consistency: FPU control state has not been set correctly
We were only interested in the list of APIs that work for emscripten and therefore we have not yet investigated failure of malloc tests. The malloc tests are disabled if they are failing.