Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump tables - ask dialog for amount of elements #213

Closed
lab313ru opened this issue Apr 22, 2016 · 3 comments
Closed

Jump tables - ask dialog for amount of elements #213

lab313ru opened this issue Apr 22, 2016 · 3 comments
Labels
enhancement This is a feature request indirect-jump This issue involves indirect jumps

Comments

@lab313ru
Copy link

It would be great to add asking of jump table elements count for situations, if program cannot identify how much elements this jump table contains.

@uxmal uxmal added the enhancement This is a feature request label Apr 22, 2016
@uxmal
Copy link
Owner

uxmal commented Apr 22, 2016

Good suggestion! I'm thinking that reko should show a Warning, and if you click on the warning, you get the dialog where you specify the jump table bounds.

@uxmal
Copy link
Owner

uxmal commented May 27, 2016

Adding this link for reference: https://github.com/joelpx/plasma/wiki/jumptable

uxmal added a commit that referenced this issue May 29, 2016
uxmal added a commit that referenced this issue Sep 19, 2016
Added JumpVectorNavigator
uxmal added a commit that referenced this issue Sep 19, 2016
uxmal added a commit that referenced this issue Sep 19, 2016
@uxmal
Copy link
Owner

uxmal commented Sep 23, 2016

I've made changes to the Reko GUI so that if you get a warning to the effect of "unable to resolve jump table", you can double click it and a dialog pops up, looking like this:

reko

Note that the feature is not yet complete, but is a prototype. If you have the time, play with the dialog and then add comments and suggestions here.

@uxmal uxmal added the indirect-jump This issue involves indirect jumps label Jan 31, 2018
@uxmal uxmal closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature request indirect-jump This issue involves indirect jumps
Projects
None yet
Development

No branches or pull requests

2 participants