Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interprocedural jumps confuse Reko scanner #90

Closed
lab313ru opened this issue Dec 24, 2015 · 3 comments
Closed

Interprocedural jumps confuse Reko scanner #90

lab313ru opened this issue Dec 24, 2015 · 3 comments
Labels
bug This issue describes a defect in Reko

Comments

@lab313ru
Copy link

At this file there are many errors starting from the second step.
PP.zip

@uxmal
Copy link
Owner

uxmal commented Dec 24, 2015

Thanks for reporting this. I am currently away on holiday but will look into this when I get back.

@uxmal uxmal added the bug This issue describes a defect in Reko label Dec 24, 2015
@uxmal uxmal changed the title MS-DOS and decompilation errors Interprocedural jumps confuse Reko scanner Dec 24, 2015
@uxmal
Copy link
Owner

uxmal commented Dec 24, 2015

(changed the title from: "MS-DOS and decompilation errors"). The root cause of the errors here is a large number of cross procedure jumps in the provided binary. The reko scanner makes a weak attempt at handling this, but in order to fix the issue I will require some serious thinking about how to handle this "the right way".

The principal difficulty is that the reko scanner is responsible for building Procedures from basic blocks. The cross-procedure jumps violate some central assumptions the scanner is depending on.

As mentioned, I'm on holiday and can't focus too much on this just now but will hopefully think of something after returning home.

@uxmal
Copy link
Owner

uxmal commented Apr 20, 2018

At long last, this issue has been fixed. The indirect jumps no longer cause crashes.

@uxmal uxmal closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect in Reko
Projects
None yet
Development

No branches or pull requests

2 participants