enhance(cypress): extend coverage of test suite, extract functions and simplify structure #4299
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 1509427 | Triggered | Generic Password | 6a94327 | cypress/cypress.config.ts | View secret |
| 1509427 | Triggered | Generic Password | 6a94327 | packages/prisma/src/data/seedTEST.ts | View secret |
| 1509427 | Triggered | Generic Password | 6a94327 | packages/prisma/src/data/seedTEST.ts | View secret |
| 1509427 | Triggered | Generic Password | cddb1af | cypress/cypress.config.ts | View secret |
| 14050276 | Triggered | Generic Password | 6a94327 | packages/prisma/src/data/seedTEST.ts | View secret |
| 14050276 | Triggered | Generic Password | 6a94327 | packages/prisma/src/data/seedTEST.ts | View secret |
| 14050276 | Triggered | Generic Password | 6a94327 | cypress/cypress.config.ts | View secret |
| 14050276 | Triggered | Generic Password | cddb1af | cypress/cypress.config.ts | View secret |
| 14050276 | Triggered | Generic Password | f42a129 | cypress/cypress.config.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
📝 Walkthrough📝 WalkthroughWalkthroughThis pull request includes several updates across multiple components in the frontend and testing suites. Key changes involve the addition of dynamic Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🔇 Additional comments (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
klicker-uzh
|
||||||||||||||||||||||||
| Project |
klicker-uzh
|
| Run status |
|
| Run duration | 08m 58s |
| Commit |
|
| Committer | Julius Schlapbach |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
92
|
…ion functionality coverage
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
klicker-uzh
|
||||||||||||||||||||||||
| Project |
klicker-uzh
|
| Run status |
|
| Run duration | 09m 20s |
| Commit |
|
| Committer | Julius Schlapbach |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
1
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
92
|
With this pull request, the test suite is rewritten in most parts to remove dependencies on seeded elements whereever possible and the allow running tests multiple times without having the re-seed the database (except from group activity run at the moment).
Additionally, the test runs reduce duplication and are split into smaller segments, separating lecturer and student test cases more cleanly and allowing to locate errors more quickly later on.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
Chores