Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/frontend-manage): fix redirect from /sessions to /quizzes evaluation and resolve bug with undefined evaluation instance #4507

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

sjschlapbach
Copy link
Member

@sjschlapbach sjschlapbach commented Feb 7, 2025

Summary by CodeRabbit

  • Chores

    • Updated URL redirection to handle extended path segments, ensuring smoother navigation.
  • New Features

    • Introduced a notification element that informs users when evaluation data is unavailable, providing clearer guidance during the evaluation process.
    • Added a new component, EvaluationUnavailableNotification, to enhance user experience when evaluation data is missing.

…aluation and resolve bug with undefined evaluation instance
Copy link

aviator-app bot commented Feb 7, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 7, 2025
Copy link

coderabbitai bot commented Feb 7, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request modifies the routing configuration and evaluation notification logic. The next.config.mjs file now utilizes wildcard matching in its redirect rule, changing the source and destination URLs. In the evaluation components, a new EvaluationUnavailableNotification component is introduced and integrated into both the ActivityEvaluation component and the quiz evaluation page to handle missing evaluation data using conditional rendering and optional chaining.

Changes

File(s) Change Summary
apps/frontend-manage/next.config.mjs Modified redirect rule by updating the source from /sessions/:id to /sessions/:id* and the destination from /quizzes/:id to /quizzes/:id* for wildcard matching.
apps/frontend-manage/.../ActivityEvaluation.tsx, apps/frontend-manage/.../evaluation.tsx Updated evaluation UI components to replace the previous user notification with the new EvaluationUnavailableNotification component and added optional chaining for safer access to evaluation data.
apps/frontend-manage/.../EvaluationUnavailableNotification.tsx Added a new component that displays an evaluation unavailability message using the next-intl translations and the design system’s UserNotification styling.

Possibly related PRs

Suggested labels

dependencies, size:L


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9de0110 and 1b09207.

📒 Files selected for processing (1)
  • apps/frontend-manage/src/components/evaluation/ActivityEvaluation.tsx (4 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cypress bot commented Feb 7, 2025

klicker-uzh    Run #4314

Run Properties:  status check passed Passed #4314  •  git commit 8883958a86 ℹ️: Merge 1b09207a23909d9cff8e9a634e15cd1869a6ca59 into 7cccc0c7c06047112a6a95fa48ff...
Project klicker-uzh
Branch Review redirect-live-session-evaluation
Run status status check passed Passed #4314
Run duration 26m 14s
Commit git commit 8883958a86 ℹ️: Merge 1b09207a23909d9cff8e9a634e15cd1869a6ca59 into 7cccc0c7c06047112a6a95fa48ff...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 349
View all changes introduced in this branch ↗︎

@sjschlapbach sjschlapbach merged commit 035c81d into v3 Feb 7, 2025
10 checks passed
@sjschlapbach sjschlapbach deleted the redirect-live-session-evaluation branch February 7, 2025 16:42
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

cypress bot commented Feb 7, 2025

klicker-uzh    Run #4315

Run Properties:  status check passed Passed #4315  •  git commit 035c81d4b6: fix(apps/frontend-manage): fix redirect from /sessions to /quizzes evaluation an...
Project klicker-uzh
Branch Review v3
Run status status check passed Passed #4315
Run duration 25m 45s
Commit git commit 035c81d4b6: fix(apps/frontend-manage): fix redirect from /sessions to /quizzes evaluation an...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 349
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

1 participant