Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAR-5390][External] Add 'extract video-artifacts' command #980

Conversation

AndriiKlymchuk
Copy link
Contributor

@AndriiKlymchuk AndriiKlymchuk commented Dec 12, 2024

Problem

For read only registration of videos in SECTIONED_V2 format clients need to prepare all processing artifacts them-self.
It is very complicated as requires to perform a lot of steps.

Solution

Develop extract video-artifacts vommand that creates all artifacts and generates metadata file containing payload for registration.

Copy link

linear bot commented Dec 12, 2024

@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch from 7e3240d to ccbe1f7 Compare December 12, 2024 12:59
@JBWilkie
Copy link
Collaborator

Looks good, and works well when I test it. To get into the repo I think we should consider:

  • Allowing the script to process multiple videos from a single command, perhaps it could work on a directory of files
  • Adding an explicit warning / documentation stating that this may become out of sync with our backend video processing pipeline
  • Placing it in a new darwin/scripts directory or similar, as no scripts of this type exist in darwin-py currently

@AndriiKlymchuk
Copy link
Contributor Author

Looks good, and works well when I test it. To get into the repo I think we should consider:

  • Allowing the script to process multiple videos from a single command, perhaps it could work on a directory of files
  • Adding an explicit warning / documentation stating that this may become out of sync with our backend video processing pipeline
  • Placing it in a new darwin/scripts directory or similar, as no scripts of this type exist in darwin-py currently

Agree. Also we need to cover it by tests.
I also sync maybe it shouldn't be a separate script, but rather part of darwin py cli?

@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch from ccbe1f7 to 8f02a99 Compare December 13, 2024 21:25
@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch 3 times, most recently from c0ff0d1 to 9eb9204 Compare January 28, 2025 14:07
@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch from 9eb9204 to 743217b Compare January 28, 2025 14:26
@AndriiKlymchuk AndriiKlymchuk changed the title Script for processing a video and generating SECTIONED_V2 artifacts for read-only item registration [DAR-5390][External] Add 'extract video-artifacts' command Jan 28, 2025
Copy link

linear bot commented Jan 28, 2025

@JBWilkie
Copy link
Collaborator

@AndriiKlymchuk Only issue is that ffmpeg@5 will be missing from the CI environment. Perhaps we can add a command here to install it?

@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch 6 times, most recently from 117dc23 to d0e1223 Compare January 28, 2025 23:34
@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch from d0e1223 to 7bffe1e Compare January 28, 2025 23:42
@AndriiKlymchuk AndriiKlymchuk merged commit 68e080b into master Jan 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants