Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAR-5371] Removed NifTI export pixdim scaling #990

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

JBWilkie
Copy link
Collaborator

@JBWilkie JBWilkie commented Jan 8, 2025

Problem

When exporting annotations from medical files, we need to perform a transformation from millimetre space to pixel space by dividing annotation coordinates by the appropriate pixdim values based on the primary plane. The problem is that currently, we only apply this transformation for NifTI exports, and we want to apply it to all annotation formats. Additionally, the existing transformation does not take the primary plane into account. We assume that the file was axially-acquired since we use pixdim[0] and pixdim[1]

Solution

This PR removes the pixdim scaling from the NifTI exporter. It is being re-applied to all appropriate medical files in backend as part of DAR-5339, where we will introduce handling for non-axially-acquired images as well

Changelog

Removed pixdim scaling from the NifTI exporter as this will be placed into backend directly

@JBWilkie JBWilkie changed the title Removed NifTI export pixdim scaling [DAR-5371] Removed NifTI export pixdim scaling Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant