Add korangar_networking crate
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rework splits the networking system to a separate crate and moves the processing to a networking thread. The main thread will no longer be blocked by networking operations, which was the main reason for the client freezing. I took this opportunity to also refactor the way that networking routines are handled. Instead of sending a packet and waiting for a response, the request and response are completely decoupled, offering more resilience to packets arriving out of order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rework splits the networking system to a separate crate and moves the processing to a networking thread. The main thread will no longer be blocked by networking operations, which was the main reason for the client freezing.
I took this opportunity to also refactor the way that networking routines are handled. Instead of sending a packet and waiting for a response, the request and response are completely decoupled, offering more resilience to packets arriving out of order.