This repository has been archived by the owner on Aug 28, 2019. It is now read-only.
Update to react-scripts 2.0.0, include polyfills properly #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
make-react-work
branch
from
3bbbaf3 to
2b401e4
Compare
web-padawan
force-pushed
the
make-react-work
branch
2 times, most recently
from
9131fc9 to
6b3a3be
Compare
web-padawan
force-pushed
the
make-react-work
branch
from
6b3a3be to
bb6fd70
Compare
|
Awsome awesome stuff. I'll try to replicate it in my own project as a validation point. |
limonte
suggested changes
Sep 28, 2018
tomivirkki
approved these changes
Sep 28, 2018
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
limonte
approved these changes
Sep 28, 2018
This was referenced Sep 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Fixes #13
Fixes #15
@amahdy @Peppe FYI and please try if this works.
Note: in polyfilled browsers there is still an issue: styles do not apply to one of the components.
Will create a separate ticket for that.
Now we need to get this merged as https://vaadin.com/start/latest/react refers to
p3-previewThis change is