chore: add load-on-startup configuration for custom Vaadin servlet #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Flow 23.2, Vite dev-server needs VaadinServlet to be initialized before to start. In order to have Vite starting eagerly (before any HTTP request), VaadinServlet must be registered with load-on-startup attribute to a value greater than zero. For custom VaadinServlet this must be done explicitly by the developer. This change updates example code defining custom Vaadin Servlet by adding load-on-startup setting. Part of vaadin/flow#14479
github-actions
bot
added
the
Language unchecked
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jouni
removed
the
Language unchecked
mshabarov
reviewed
Sep 19, 2022
mshabarov
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Flow 23.2, Vite dev-server needs VaadinServlet to be initialized before to start. In order to have Vite starting eagerly (before any HTTP request), VaadinServlet must be registered with load-on-startup attribute to a value greater than zero. For custom VaadinServlet this must be done explicitly by the developer.
This change updates example code defining custom Vaadin Servlet by adding load-on-startup setting.
Part of vaadin/flow#14479