feat: add Checkbox helper and CheckboxGroup item helper generator #6166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/checkbox-helper
branch
from
4d352cb to
8a52b00
Compare
web-padawan
changed the title
knoobie
reviewed
Apr 2, 2024
| } | ||
|
|
||
| @Test | ||
| public void assertCheckboxHelperText() { |
There was a problem hiding this comment.
Just wondering: How can the test pass and the PR check returning green while the web-components PR with the implementation of this not merged?
There was a problem hiding this comment.
Good point. I think this is because we use getHelperText() / getHelperComponent() API without checking for the actual presence of <div slot="helper"> element in the DOM. I will add a separate test for that.
web-padawan
force-pushed
the
feat/checkbox-helper
branch
from
4e86ef8 to
d12c9e9
Compare
This was referenced Apr 11, 2024
...-flow-integration-tests/src/test/java/com/vaadin/flow/component/checkbox/tests/HelperIT.java
Outdated
Show resolved
Hide resolved
...-flow-integration-tests/src/test/java/com/vaadin/flow/component/checkbox/tests/HelperIT.java
Outdated
Show resolved
Hide resolved
...-flow-integration-tests/src/test/java/com/vaadin/flow/component/checkbox/tests/HelperIT.java
Outdated
Show resolved
Hide resolved
...-flow-integration-tests/src/test/java/com/vaadin/flow/component/checkbox/tests/HelperIT.java
Outdated
Show resolved
Hide resolved
...-flow-integration-tests/src/test/java/com/vaadin/flow/component/checkbox/tests/HelperIT.java
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
feat/checkbox-helper
branch
from
2f1d063 to
d1758b6
Compare
sissbruecker
approved these changes
Apr 15, 2024
|
|
This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of vaadin/platform#5190
Depends on vaadin/web-components#7285
Type of change