fix: prevent setting disabled to false with pointer events: auto #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Apr 15, 2024
...on-flow-integration-tests/src/test/java/com/vaadin/flow/component/button/tests/ButtonIT.java
Outdated
Show resolved
Hide resolved
vursen
approved these changes
Apr 15, 2024
…/src/test/java/com/vaadin/flow/component/button/tests/ButtonIT.java Co-authored-by: Sergey Vinogradov <[email protected]>
|
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 16, 2024
…) (#6205) Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6183
This changes the client side JS listener as suggested in the issue to only set
disabledtotrueand notfalse.Type of change
Note
The IT setup represents an edge case as it uses
setDisableOnClick(true)followed bysetDisableOnClick(false)and is based on the code example #6183 (comment). Also, clicking the button in the IT requires firing an event manually.