feat: add initial Popover component implementation #6332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/popover-initial
branch
4 times, most recently
from
61ddb5c to
a69ab61
Compare
vursen
reviewed
May 30, 2024
...-flow-integration-tests/src/test/java/com/vaadin/flow/component/popover/tests/PopoverIT.java
Outdated
Show resolved
Hide resolved
...-flow-integration-tests/src/test/java/com/vaadin/flow/component/popover/tests/PopoverIT.java
Outdated
Show resolved
Hide resolved
| * Constructs an empty popover. | ||
| */ | ||
| public Popover() { | ||
| getElement().getNode().addAttachListener(this::attachComponentRenderer); |
There was a problem hiding this comment.
Could be moved to onAttach?
There was a problem hiding this comment.
This was added in Dialog in this PR: vaadin/vaadin-dialog-flow#128. I'm not sure if onAttach works the same as getNode().addAttachListener() so I'd prefer to keep this in line with the Dialog logic.
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Show resolved
Hide resolved
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
feat/popover-initial
branch
from
cac0276 to
d8216b5
Compare
tomivirkki
approved these changes
May 31, 2024
|
|
This ticket/PR has been released with Vaadin 24.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of vaadin/platform#5271
The following logic is implemented:
PopoverChildrenTestcopied fromDialogHasStylePopoverHasStyleTestcopied fromDialogsetTarget()andgetTarget()setFor()andgetFor()setPosition()andgetPosition()PopoverPositionenum is a copy ofTooltipPositionType of change