Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace formatter with spotless [skip ci] #6512

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

sissbruecker
Copy link
Contributor

Replaces the formatter-maven-plugin with spotless.

This uses a minimal configuration for now that results in minimal formatting changes, which allows cherry-picking to version branches. A follow-up PR could enable further features and reformat the code on main.

@sissbruecker sissbruecker marked this pull request as ready for review August 9, 2024 07:55
@sissbruecker sissbruecker force-pushed the chore/replace-formatter-with-spotless branch from 554b001 to e6ac50b Compare August 9, 2024 08:16
@sissbruecker sissbruecker changed the title chore: replace formatter with spotless chore: replace formatter with spotless [skip ci] Aug 9, 2024
Copy link

sonarqubecloud bot commented Aug 9, 2024

@sissbruecker sissbruecker force-pushed the chore/replace-formatter-with-spotless branch from f098a0e to e6ac50b Compare August 9, 2024 08:21
@ZheSun88 ZheSun88 merged commit aa143ec into main Aug 9, 2024
4 checks passed
@ZheSun88 ZheSun88 deleted the chore/replace-formatter-with-spotless branch August 9, 2024 08:35
@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @ZheSun88, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick aa143ec
error: could not apply aa143ec... chore: replace formatter with spotless [skip ci] (#6512)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @ZheSun88, when i performed cherry-pick to this commit to 23.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick aa143ec
error: could not apply aa143ec... chore: replace formatter with spotless [skip ci] (#6512)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @ZheSun88, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick aa143ec
error: could not apply aa143ec... chore: replace formatter with spotless [skip ci] (#6512)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @ZheSun88, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick aa143ec
error: could not apply aa143ec... chore: replace formatter with spotless [skip ci] (#6512)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

sissbruecker added a commit that referenced this pull request Aug 9, 2024
sissbruecker added a commit that referenced this pull request Aug 9, 2024
sissbruecker added a commit that referenced this pull request Aug 9, 2024
sissbruecker added a commit that referenced this pull request Aug 9, 2024
sissbruecker added a commit that referenced this pull request Aug 9, 2024
sissbruecker added a commit that referenced this pull request Aug 9, 2024
vaadin-bot pushed a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants