Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make disabled buttons accessible with feature flag #7050

Merged
merged 18 commits into from
Jan 27, 2025

Conversation

@vursen vursen marked this pull request as draft January 17, 2025 07:49
@vursen vursen force-pushed the feat/focusable-disabled-buttons branch from bc44794 to d897a39 Compare January 17, 2025 15:02
@vursen vursen changed the title feat: explain how to make disabled buttons focusable feat: make disabled buttons focusable with feature flag Jan 17, 2025
@vursen vursen changed the title feat: make disabled buttons focusable with feature flag feat: make disabled buttons accessible with feature flag Jan 21, 2025
@vursen vursen force-pushed the feat/focusable-disabled-buttons branch 3 times, most recently from af82a4a to e359ef8 Compare January 22, 2025 06:19
@vursen vursen force-pushed the feat/focusable-disabled-buttons branch from 6b11d8f to f0baadd Compare January 23, 2025 14:29
@vursen vursen marked this pull request as ready for review January 23, 2025 15:17
@vursen vursen requested review from DiegoCardoso and removed request for tomivirkki January 27, 2025 09:35
@vursen vursen force-pushed the feat/focusable-disabled-buttons branch from c8053f4 to 5fa0a04 Compare January 27, 2025 13:34
@vursen vursen force-pushed the feat/focusable-disabled-buttons branch from 5fa0a04 to d557cb5 Compare January 27, 2025 13:34
…/vaadin/flow/component/button/tests/AccessibleDisabledButtonTest.java
Copy link

@vursen vursen merged commit d4885c7 into main Jan 27, 2025
5 checks passed
@vursen vursen deleted the feat/focusable-disabled-buttons branch January 27, 2025 15:22
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha7 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants