Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PiT] switching between different views results in wrong url #20671

Closed
Tracked by #7057
ZheSun88 opened this issue Dec 11, 2024 · 8 comments · Fixed by #20673
Closed
Tracked by #7057

[PiT] switching between different views results in wrong url #20671

ZheSun88 opened this issue Dec 11, 2024 · 8 comments · Fixed by #20673

Comments

@ZheSun88
Copy link
Contributor

Description of the bug

for a multi view app, when i switch between different views, the url will be ended in a wron format.
check GIF
multi-view-24 6 0 beta4

Expected behavior

app works

Minimal reproducible example

curl -s -f 'https://start.vaadin.com/dl?&preset=latest-java&preset=partial-auth&projectName=latest-java_partial-auth' -o 'latest-java_partial-auth.zip'
unzip -q 'latest-java_partial-auth.zip'
cd 'latest-java-partial-auth'
perl -pi -e 's|(\s*<'vaadin.version'>)[^\s]+(</'vaadin.version'>)|${1}24.6.0.beta4${2}|g' pom.xml
perl -pi -e 's|(\s*)(<repositories>)|$1$2\n$1$1<repository><id>v</id><url>https://maven.vaadin.com/vaadin-prereleases</url></repository>|' pom.xml
perl -pi -e 's|(\s*)(</project>)|$1$1<pluginRepositories><pluginRepository><id>v</id><url>https://maven.vaadin.com/vaadin-prereleases</url></pluginRepository></pluginRepositories>\n$1$2|' pom.xml
perl -pi -e 's|<java.version>21</java.version>|<java.version>17</java.version>|' pom.xml
./mvnw

then navigate to `localhost:8080`
login the app admin/admin
switch between views like in the gif

Versions

  • Vaadin / Flow version:24.6.0.beta4/24.6.0.beta8 (hilla version 24.6.0.beta7)
@caalador
Copy link
Contributor

Is this changing routes between flow routes using a hilla main layout?

@caalador
Copy link
Contributor

I can see this appending of the navigation route if I use a slowed down connection for the application.

@mshabarov
Copy link
Contributor

I couldn't reproduce even with 3G and slow 4G:
appending-path

@mshabarov
Copy link
Contributor

UPD: I can reproduce with 3G, but it's very rare and I have to click very fast.

@mshabarov
Copy link
Contributor

What I noticed on the GIF in the description is that the dashboard menu link isn't highlighted when clicked, which may be a sign of very slow reaction of browser 🤔

@ZheSun88
Copy link
Contributor Author

ZheSun88 commented Dec 11, 2024

i wonder why it has not been caught in previous beta or other flow versions.

has something changed which make it visible?

oh, yes.. i was testing with my phone 5G hotspot

@caalador caalador self-assigned this Dec 11, 2024
caalador added a commit that referenced this issue Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671
vaadin-bot pushed a commit that referenced this issue Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671
vaadin-bot pushed a commit that referenced this issue Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671
vaadin-bot added a commit that referenced this issue Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671

Co-authored-by: caalador <[email protected]>
vaadin-bot added a commit that referenced this issue Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671

Co-authored-by: caalador <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.rc1 and is also targeting the upcoming stable 24.6.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment