HotSwapAgent refreshes UI after Dialog open

[Hankonen]

Description of the bug

If I have hotswap enabled and I open a Dialog for example from a Button press it closes immediately since hotswap refreshes the UI. I saw some other wierd UI refreshing happening all around but the Dialog was the easiest to pinpoint as the other cases were not so visible (e.g. some partial refresh just before changing views etc.).

Expected behavior

The UI should not be refreshed by hotswap if no actual change has occurred.

Minimal reproducible example

My setup was:
Eclipse 2024-09
Tomcat 10.1.31

JetBrainsRuntime from https://github.com/JetBrains/JetBrainsRuntime/releases/tag/jbr17_0_1b164.4
(windows-x64 JBR with JCEF (DCEVM))

HotSwapAgent from https://github.com/HotswapProjects/HotswapAgent/releases
(version 2.0.0)
Add the hotswap-agent.jar to YOUR_PATH/jbr/lib/hotswap/ directory (remove the version numbers from the name of the .jar file).

Get the plain Java Vaadin starter: https://github.com/vaadin/skeleton-starter-flow/archive/v24.zip
(Vaadin version 24.5.7 or 24.5.8)

Import the starter to Eclipse and add a new Tomcat 10.1 server and the starter module to it.
Set the JetBrainsRuntime as the JRE for the server.
Add this to the servers Launch configurations Arguments:
-XX:+AllowEnhancedClassRedefinition -XX:HotswapAgent=fatjar

In the starters MainView.class add a Button in the constructor:

		this.add(new Button("Test", e -> {
			Dialog d = new Dialog();
			d.open();
		}));

Start the server and navigate to the application in browser.
When clicking the "Test" button a Dialog should pop open and then immediately close.

Versions

• Vaadin / Flow version: 24.5.7 and 24.5.8
• Java version: 17
• OS version: Windows 10
• Application Server (if applicable): Tomcat 10.1.31
• IDE (if applicable): Eclipse 2024-09

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.5.9.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.6.1.