Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatically use jar resource listener in a multimodule Maven project #16738

Merged
merged 9 commits into from
May 10, 2023

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented May 4, 2023

No description provided.

@Artur- Artur- force-pushed the detect-multimodule-maven branch from 3137b56 to ddaa800 Compare May 4, 2023 12:05
@github-actions
Copy link

github-actions bot commented May 4, 2023

Test Results

   987 files  ±  0     987 suites  ±0   1h 20m 37s ⏱️ - 7m 59s
6 254 tests +  6  6 214 ✔️ +  6  40 💤 ±0  0 ±0 
6 504 runs  +18  6 459 ✔️ +18  45 💤 ±0  0 ±0 

Results for commit ba86f68. ± Comparison against base commit 7a1eec5.

♻️ This comment has been updated with latest results.

@Artur- Artur- force-pushed the detect-multimodule-maven branch 3 times, most recently from aa7b3c0 to 02f91ce Compare May 6, 2023 16:48
@Artur- Artur- force-pushed the detect-multimodule-maven branch from 02f91ce to 7bde978 Compare May 9, 2023 15:42
@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels May 9, 2023
@Artur- Artur- force-pushed the detect-multimodule-maven branch 3 times, most recently from c4e690d to e0793c1 Compare May 9, 2023 16:55
@Artur- Artur- force-pushed the detect-multimodule-maven branch from e0793c1 to 946f61e Compare May 9, 2023 17:29
@Artur- Artur- requested a review from mcollovati May 9, 2023 17:29
@Artur- Artur- marked this pull request as ready for review May 9, 2023 17:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur- Artur- enabled auto-merge (squash) May 10, 2023 13:33
@Artur- Artur- merged commit 737cfd7 into main May 10, 2023
@Artur- Artur- deleted the detect-multimodule-maven branch May 10, 2023 13:35
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants