Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add classpath elements to Surefire plugin #20871

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Jan 16, 2025

Description

Maven doesn't use .classpath and as such isn't aware that it should use flow-server as a source directory. That leads to a whole lot of Project Errors in IntelliJ IDEA if flow-client module isn't ignored. This configuration change gets rid of those errors.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Maven doesn't use .classpath and as such isn't aware that it should use flow-server as a source directory.
@mshabarov mshabarov added the Contribution PRs coming from the community or external to the team label Jan 20, 2025
@mshabarov mshabarov requested a review from mcollovati January 20, 2025 12:32
@tepi
Copy link
Contributor

tepi commented Jan 21, 2025

I can't reproduce the original issue without this change (IDEA 2024.3 & latest macos). On the other hand this change does not seem to break anything for me either.

@mcollovati
Copy link
Collaborator

I couldn't reproduce the problem either.
Honestly, I wonder how adding a source folder to the classpath elements, where compiled classes are supposed to be added, can fix project errors.
However, since the flow-client setup for 2.11 is a bit tricky and the change does not seem to break anything as @tepi said, if it solves the issues for @Ansku I agree to merge.

@mshabarov mshabarov merged commit 5a6224c into 2.11 Jan 31, 2025
9 checks passed
@mshabarov mshabarov deleted the updatePom20250116v14 branch January 31, 2025 08:18
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 14.12.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution PRs coming from the community or external to the team Released with Vaadin 14.12.5 +0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants