fix: build service worker without writing it to FS #20909
Conversation
| }, | ||
| async load(id) { | ||
| if (id.endsWith('sw.js')) { | ||
| return buildOutput.output[0].code; |
There was a problem hiding this comment.
note: The output code already includes a sourcemap link, so there is no need to return sourcemaps separately in transform(code, id) as it was done previously.
|
|
Hi @vursen and @tepi, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually? |
Co-authored-by: Sergey Vinogradov <[email protected]>
Co-authored-by: Sergey Vinogradov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.7.0.alpha6 and is also targeting the upcoming stable 24.7.0 version. |
Description
#20894 reintroduced #13123 where the service worker build would cause a server restart in dev mode. This PR fixes this issue again.
Type of change