Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP #11718 #11721

Closed
wants to merge 1 commit into from
Closed

WIP #11718 #11721

wants to merge 1 commit into from

Conversation

anasmi
Copy link
Contributor

@anasmi anasmi commented Sep 12, 2019 •
edited by Artur-
Loading

  1. Created UI test
  2. Now there is no error, when pop-up is opened and any of the optioned is hovered, when positioned right without padding/margin, but need to verify:
    • Behaviour, when there is no left padding/margin
    • pop-up still moves, when opened by multiple px. Re-positioned, when navigated

This change is Reviewable

WIP vaadin#11718
f899b9b 
1. Created UI test
2. No there is no error, when pop-up is opened and positioned right without padding/margin, but need to verify:
  - Behaviour, when there is no left padding/margin
  - pop-up still moves, when opened by multiple px. Re-positioned, when navigated
@anasmi anasmi closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anasmi