Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to popup positioning for ComboBox within HorizontalLayout. #11852

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Dec 19, 2019

(#11846)

Expand ratio and spacing can cause ComboBox to miscalculate its own
position while layouting is still ongoing. Popup should not be
repositioned in such circumstances in order to avoid incorrect
intermediate states.

Continues on #11718


This change is Reviewable

…t. (#11846)

Expand ratio and spacing can cause ComboBox to miscalculate its own
position while layouting is still ongoing. Popup should not be
repositioned in such circumstances in order to avoid incorrect
intermediate states.

Continues on #11718
Copy link
Contributor

@anasmi anasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Ansku Ansku merged commit f3fa6ca into 8.9 Dec 19, 2019
@Ansku Ansku deleted the issue11718expandedRelease branch December 19, 2019 15:56
@Ansku Ansku added this to the 8.9.4 milestone Dec 19, 2019
@dyachera
Copy link

dyachera commented Jan 8, 2020

I just recently updated to 8.9.4 and it looks like this caused the combo box on one of my windows to no longer function correctly so I cannot upgrade to latest. Before this I had a combobox on a window in a horizontalLayout at the bottom of the window and when you opened up the options the select options rendered above the combobox so you could see all available options. After upgrading to 8.9.4 when I go to click on the comboBox I can only see one option and all the others render off the screen below the combobox. I have to hover over the first option and press the down arrow key in order for them to be shown. This does not happen in 8.9.3 or 8.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants