test: Run tests using React 19 + 18 (#2962)

vaadin · Feb 28, 2025 · d28cdc3 · d28cdc3
1 parent 24b3623
commit d28cdc3
Show file tree

Hide file tree

Showing 17 changed files with 180 additions and 22 deletions.
diff --git a/.github/workflows/validation.yml b/.github/workflows/validation.yml
@@ -91,8 +91,6 @@ jobs:
     name: Check style
     runs-on: ubuntu-latest
     timeout-minutes: 25
-    strategy:
-      fail-fast: false
 
     steps:
       - name: Checkout Project Code
@@ -120,8 +118,6 @@ jobs:
     name: Test Java
     runs-on: ubuntu-latest
     timeout-minutes: 25
-    strategy:
-      fail-fast: false
 
     steps:
       - name: Checkout Project Code
@@ -160,8 +156,6 @@ jobs:
     name: Test TypeScript
     runs-on: ubuntu-latest
     timeout-minutes: 25
-    strategy:
-      fail-fast: false
 
     steps:
       - name: Install Chrome
@@ -311,6 +305,66 @@ jobs:
             packages/java/gradle-plugin/build/test-results/*
             packages/java/gradle-plugin/build/reports/*
 
+  test-react-18:
+    needs:
+      - init
+    name: React 18 Tests
+    runs-on: ubuntu-latest
+    timeout-minutes: 25
+    steps:
+      - name: Install Chrome
+        id: setup-chrome
+        uses: browser-actions/setup-chrome@v1
+      - name: Checkout Project Code
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 0
+      - name: Setup
+        uses: ./.github/actions/setup
+      - uses: actions/download-artifact@v4
+        with:
+          name: saved-workspace
+      - name: Restore Workspace
+        run: |
+          set -x
+          tar xf workspace.tar
+          tar cf - .m2 | (cd ~ && tar xf -)
+      - name: Install React 18
+        run: npm install --save-dev react@18 react-dom@18 @types/react@18 @types/react-dom@18
+      - name: Test
+        run: npm run test:react
+        env:
+          CI: true
+          CHROME_BIN: ${{ steps.setup-chrome.outputs.chrome-path }}
+      - name: Set TB License
+        run: |
+          TB_LICENSE=${{secrets.TB_LICENSE}}
+          mkdir -p ~/.vaadin/
+          echo '{"username":"'`echo $TB_LICENSE | cut -d / -f1`'","proKey":"'`echo $TB_LICENSE | cut -d / -f2`'"}' > ~/.vaadin/proKey
+      - name: Verify
+        run: |
+          (
+            cd packages/java/tests && \
+            mvn -B -am -ntp -fae \
+              -Dfailsafe.forkCount=4 \
+              -Dcom.vaadin.testbench.Parameters.testsInParallel=5 \
+              -Dfailsafe.rerunFailingTestsCount=2 \
+              -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
+              -Dmaven.wagon.http.retryHandler.count=3 \
+              -P\!it-modules \
+              -Preact-18 \
+              -Pproduction \
+              verify
+          )
+      - uses: actions/upload-artifact@v4
+        if: ${{ failure() || success() }}
+        with:
+          name: saved-outputs-it-${{ matrix.os }}-${{ matrix.it-modules }}
+          path: |
+            packages/java/tests/**/target/*-reports/*
+            packages/java/tests/**/error-screenshots/*.png
+
   test-all:
     name: Tests Summary
     runs-on: ubuntu-latest
@@ -321,12 +375,13 @@ jobs:
       - test-typescript
       - test-it
       - test-gradle
+      - test-react-18
     steps:
       - name: Merge Artifacts
         uses: actions/upload-artifact/merge@v4
         with:
           name: saved-outputs
           pattern: saved-outputs-*
       - name: Fail if test jobs did not succeed
-        if: ${{ needs.check-style.result != 'success' || needs.test-java.result != 'success' || needs.test-typescript.result != 'success' || needs.test-it.result != 'success' || needs.test-gradle.result != 'success' }}
+        if: ${{ needs.check-style.result != 'success' || needs.test-java.result != 'success' || needs.test-typescript.result != 'success' || needs.test-it.result != 'success' || needs.test-gradle.result != 'success' || needs.test-react-18.result != 'success' }}
         run: exit 1
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -22,6 +22,7 @@
     "lint:fix": "nx run-many -t lint:fix --all --output-style stream",
     "test": "nx run-many -t test --all --output-style stream",
     "test:coverage": "nx run-many -t test:coverage --all --output-style stream",
+    "test:react": "nx run-many -t test:react --all --output-style stream",
     "typecheck": "nx run-many -t typecheck --all --output-style stream"
   },
   "repository": {

diff --git a/...s/java/tests/gradle/single-module-tests/src/main/resources/vaadin-featureflags.properties b/...s/java/tests/gradle/single-module-tests/src/main/resources/vaadin-featureflags.properties
@@ -0,0 +1,2 @@
+# React 19 (default in Vaadin 25)
+com.vaadin.experimental.react19=true
diff --git a/packages/java/tests/gradle/single-module/src/main/resources/vaadin-featureflags.properties b/packages/java/tests/gradle/single-module/src/main/resources/vaadin-featureflags.properties
@@ -0,0 +1,2 @@
+# React 19 (default in Vaadin 25)
+com.vaadin.experimental.react19=true
diff --git a/packages/java/tests/pom.xml b/packages/java/tests/pom.xml
@@ -30,6 +30,9 @@
         <!-- make sure we do not leave webpack-dev-server running after IT -->
         <vaadin.reuseDevServer>false</vaadin.reuseDevServer>
 
+        <!-- enable React 19 feature flag by default -->
+        <vaadin.experimental.react19>true</vaadin.experimental.react19>
+
         <!-- Used in the tests, should be overridden for each module to support
     concurrent running of test modules. -->
         <server.port>8888</server.port>
@@ -139,6 +142,18 @@
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>properties-maven-plugin</artifactId>
+                <version>${properties-maven-plugin.version}</version>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>set-system-properties</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
@@ -252,16 +267,26 @@
                             </goals>
                             <configuration>
                                 <properties>
-                                    <vaadin.reuseDevServer>${vaadin.reuseDevServer}</vaadin.reuseDevServer>
-                  <vaadin.devmode.liveReload.enabled>
-                                    ${vaadin.devmode.liveReload.enabled}</vaadin.devmode.liveReload.enabled>
-                  <vaadin.allow.appshell.annotations>
-                                    ${vaadin.allow.appshell.annotations}</vaadin.allow.appshell.annotations>
-
-                  <jetty.scantrigger>
-                                    ${jetty.scantrigger}</jetty.scantrigger>-->                   <!-- Allow test clients not on localhost to connect to Vite-->
-                  <vaadin.devmode.vite.options>
-                                    ${vaadin.devmode.vite.options}</vaadin.devmode.vite.options>
+                                    <jetty.scantrigger>
+                                        ${jetty.scantrigger}
+                                    </jetty.scantrigger>
+                                    <vaadin.reuseDevServer>
+                                        ${vaadin.reuseDevServer}
+                                    </vaadin.reuseDevServer>
+                                    <vaadin.devmode.liveReload.enabled>
+                                        ${vaadin.devmode.liveReload.enabled}
+                                    </vaadin.devmode.liveReload.enabled>
+                                    <vaadin.allow.appshell.annotations>
+                                        ${vaadin.allow.appshell.annotations}
+                                    </vaadin.allow.appshell.annotations>
+                                    <!-- Allow test clients not on localhost
+                                    to connect to Vite -->
+                                    <vaadin.devmode.vite.options>
+                                        ${vaadin.devmode.vite.options}
+                                    </vaadin.devmode.vite.options>
+                                    <vaadin.experimental.react19>
+                                        ${vaadin.experimental.react19}
+                                    </vaadin.experimental.react19>
                                 </properties>
                             </configuration>
                         </execution>
@@ -331,5 +356,15 @@
             </modules>
         </profile>
 
+        <profile>
+            <id>react-18</id>
+            <properties>
+                <vaadin.experimental.react19>false</vaadin.experimental.react19>
+            </properties>
+            <modules>
+                <module>spring</module>
+            </modules>
+        </profile>
+
     </profiles>
 </project>
diff --git a/packages/java/tests/spring/pom.xml b/packages/java/tests/spring/pom.xml
@@ -130,6 +130,44 @@
                             </goals>
                         </execution>
                     </executions>
+                    <configuration>
+                        <systemPropertyVariables>
+                            <vaadin.reuseDevServer>
+                                ${vaadin.reuseDevServer}
+                            </vaadin.reuseDevServer>
+                            <vaadin.devmode.liveReload.enabled>
+                                ${vaadin.devmode.liveReload.enabled}
+                            </vaadin.devmode.liveReload.enabled>
+                            <vaadin.allow.appshell.annotations>
+                                ${vaadin.allow.appshell.annotations}
+                            </vaadin.allow.appshell.annotations>
+                            <!-- Allow test clients not on localhost
+                            to connect to Vite -->
+                            <vaadin.devmode.vite.options>
+                                ${vaadin.devmode.vite.options}
+                            </vaadin.devmode.vite.options>
+                            <vaadin.experimental.react19>
+                                ${vaadin.experimental.react19}
+                            </vaadin.experimental.react19>
+                            <vaadin.reuseDevServer>
+                                ${vaadin.reuseDevServer}
+                            </vaadin.reuseDevServer>
+                            <vaadin.devmode.liveReload.enabled>
+                                ${vaadin.devmode.liveReload.enabled}
+                            </vaadin.devmode.liveReload.enabled>
+                            <vaadin.allow.appshell.annotations>
+                                ${vaadin.allow.appshell.annotations}
+                            </vaadin.allow.appshell.annotations>
+                            <!-- Allow test clients not on localhost
+                            to connect to Vite-->
+                            <vaadin.devmode.vite.options>
+                                ${vaadin.devmode.vite.options}
+                            </vaadin.devmode.vite.options>
+                            <vaadin.experimental.react19>
+                                ${vaadin.experimental.react19}
+                            </vaadin.experimental.react19>
+                        </systemPropertyVariables>
+                    </configuration>
                 </plugin>
             </plugins>
         </pluginManagement>
@@ -231,6 +269,16 @@
             </modules>
         </profile>
 
+        <profile>
+            <id>react-18</id>
+            <modules>
+                <module>no-endpoints</module>
+                <module>react-grid-test</module>
+                <module>react-i18n</module>
+                <module>react-signals</module>
+            </modules>
+        </profile>
+
         <profile>
             <id>native</id>
             <modules>

diff --git a/packages/java/tests/spring/react-grid-test/src/main/resources/vaadin-featureflags.properties b/packages/java/tests/spring/react-grid-test/src/main/resources/vaadin-featureflags.properties
@@ -0,0 +1,4 @@
+# Enable Hilla I18n feature flag so that we can test it
+com.vaadin.experimental.hillaI18n=true
+# React 19 (default in Vaadin 25)
+com.vaadin.experimental.react19=true
diff --git a/packages/java/tests/spring/react-i18n/src/main/resources/vaadin-featureflags.properties b/packages/java/tests/spring/react-i18n/src/main/resources/vaadin-featureflags.properties
@@ -1,2 +1,4 @@
 # Enable Hilla I18n feature flag so that we can test it
 com.vaadin.experimental.hillaI18n=true
+# React 19 (default in Vaadin 25)
+com.vaadin.experimental.react19=true
diff --git a/packages/java/tests/spring/react-signals/src/main/resources/vaadin-featureflags.properties b/packages/java/tests/spring/react-signals/src/main/resources/vaadin-featureflags.properties
@@ -1,2 +1,4 @@
 # Experimental feature flags for Vaadin
 com.vaadin.experimental.fullstackSignals=true
+# React 19 (default in Vaadin 25)
+com.vaadin.experimental.react19=true
diff --git a/packages/ts/file-router/package.json b/packages/ts/file-router/package.json
@@ -25,6 +25,7 @@
     "lint:fix": "eslint src test --fix",
     "test": "vitest --run",
     "test:coverage": "vitest --run --coverage",
+    "test:react": "npm run test",
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit"
   },

diff --git a/packages/ts/generator-plugin-transfertypes/package.json b/packages/ts/generator-plugin-transfertypes/package.json
@@ -13,8 +13,9 @@
     "lint": "eslint src test",
     "lint:fix": "eslint src test --fix",
     "test": "vitest --run",
-    "test:update": "vitest --update",
-    "test:coverage": "vitest --coverage",
+    "test:coverage": "vitest --run --coverage",
+    "test:update": "vitest --run --update",
+    "test:watch": "vitest",
     "typecheck": "tsc --noEmit"
   },
   "exports": {

diff --git a/packages/ts/react-auth/package.json b/packages/ts/react-auth/package.json
@@ -22,6 +22,7 @@
     "lint:fix": "eslint src test --fix",
     "test": "vitest --run",
     "test:coverage": "vitest --run --coverage",
+    "test:react": "npm run test",
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit"
   },

diff --git a/packages/ts/react-crud/package.json b/packages/ts/react-crud/package.json
@@ -22,6 +22,7 @@
     "lint:fix": "eslint src test --fix",
     "test": "vitest --run",
     "test:coverage": "vitest --run --coverage",
+    "test:react": "npm run test",
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit"
   },

diff --git a/packages/ts/react-form/package.json b/packages/ts/react-form/package.json
@@ -22,6 +22,7 @@
     "lint:fix": "eslint src test --fix",
     "test": "vitest --run",
     "test:coverage": "vitest --run --coverage",
+    "test:react": "npm run test",
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit"
   },

diff --git a/packages/ts/react-i18n/package.json b/packages/ts/react-i18n/package.json
@@ -22,6 +22,7 @@
     "lint:fix": "eslint src test --fix",
     "test": "vitest --run",
     "test:coverage": "vitest --run --coverage",
+    "test:react": "npm run test",
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit"
   },

diff --git a/packages/ts/react-signals/package.json b/packages/ts/react-signals/package.json
@@ -22,6 +22,7 @@
     "lint:fix": "eslint src test --fix",
     "test": "vitest --run",
     "test:coverage": "vitest --run --coverage",
+    "test:react": "npm run test",
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit"
   },
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# React 19 (default in Vaadin 25)
		com.vaadin.experimental.react19=true