-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NumberSignal basic support #2502
Conversation
Why is |
packages/java/endpoint/src/main/java/com/vaadin/hilla/signals/core/EventQueue.java
Outdated
Show resolved
Hide resolved
Good catch. That was unintentionally committed/pushed. Reverted. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2502 +/- ##
==========================================
+ Coverage 92.56% 92.58% +0.02%
==========================================
Files 69 71 +2
Lines 2245 2265 +20
Branches 590 591 +1
==========================================
+ Hits 2078 2097 +19
- Misses 120 121 +1
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/java/endpoint/src/main/java/com/vaadin/hilla/signals/core/SignalsRegistry.java
Show resolved
Hide resolved
packages/java/endpoint/src/main/java/com/vaadin/hilla/EndpointController.java
Outdated
Show resolved
Hide resolved
packages/java/endpoint/src/main/java/com/vaadin/hilla/signals/NumberSignal.java
Outdated
Show resolved
Hide resolved
|
This ticket/PR has been released with Hilla 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
Description
Add basic support for full-stack
NumberSignal
type to be returned by endpoints as a shared signal instance that supports number value operations. The client-side user code (for now) need to do manual wrapping of the needed metadata about the endpoint method(s) that return shared signal instance(s).Assuming a simple endpoint returning a
NumberSignal
instance like this:The needed manually written user code is like this (this will be generated later):
Then then usage of this wrapping service in views could be similar to what is described in the related issue:
NOTE: Since the Full-stack signals are experimental for now, please don't forget to enable the
fullstackSignals
feature flag in your applications (by adding the following insrc/main/resources/vaadin-featureflags.properties
):Fixes #2429
Type of change
Checklist
Additional for
Feature
type of change