Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lit-form): deprecate AbstractModel methods that require BinderNode #2522

Merged
merged 16 commits into from
Jul 17, 2024
Merged

refactor(lit-form): deprecate AbstractModel methods that require BinderNode #2522

merged 16 commits into from
Jul 17, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Jun 7, 2024

Resolves #2060.

@Lodin Lodin added the hilla Issues related to Hilla label Jun 7, 2024
@Lodin Lodin requested a review from platosha June 7, 2024 16:00
@codecov Codecov
Copy link

codecov bot commented Jun 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (e2725b4) to head (3d479c4).

Files Patch % Lines
packages/ts/lit-form/src/Validation.ts 0.00% 0 Missing and 2 partials ⚠️
packages/ts/lit-form/src/Models.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
- Coverage   92.76%   92.56%   -0.21%     
==========================================
  Files          69       69              
  Lines        2239     2245       +6     
  Branches      587      590       +3     
==========================================
+ Hits         2077     2078       +1     
- Misses        117      120       +3     
- Partials       45       47       +2
Flag Coverage Δ
unittests 92.56% <75.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

platosha
platosha previously approved these changes Jun 13, 2024
View reviewed changes
@Lodin Lodin force-pushed the refactor/lit-form/binder-node branch from a667019 to 20f676b Compare June 19, 2024 18:51
@Lodin Lodin requested a review from platosha June 19, 2024 18:51
platosha
platosha requested changes Jun 26, 2024
View reviewed changes
packages/ts/lit-form/src/Models.ts Outdated Show resolved Hide resolved
packages/ts/lit-form/src/Models.ts Show resolved Hide resolved
platosha
platosha previously requested changes Jun 27, 2024
View reviewed changes
packages/ts/lit-form/src/Models.ts Outdated Show resolved Hide resolved
packages/ts/lit-form/src/index.ts Outdated Show resolved Hide resolved
@Lodin Lodin requested a review from platosha June 28, 2024 14:44
@Lodin Lodin requested a review from cromoteca July 8, 2024 15:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cromoteca cromoteca removed the request for review from platosha July 17, 2024 08:16
@cromoteca cromoteca requested a review from platosha July 17, 2024 08:16
@cromoteca cromoteca merged commit 306b086 into main Jul 17, 2024
12 of 14 checks passed
@cromoteca cromoteca deleted the refactor/lit-form/binder-node branch July 17, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cromoteca cromoteca cromoteca approved these changes

@platosha platosha Awaiting requested review from platosha

Assignees
No one assigned
Labels
hilla Issues related to Hilla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lit-form] make model API not depend on form binder
3 participants
@Lodin @platosha @cromoteca