-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for JsonNode subclasses #2537
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 66 66
Lines 4546 4546
Branches 661 661
=======================================
Hits 4319 4319
Misses 182 182
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just wondering: should we rather represent JsonObject as |
I was thinking the same thing, but mostly for simple types like numbers and strings which are transmitted as they are. But I don't expect classes like |
I decided to only support the 3 non-raw-value classes, which also removes the need to use ClassGraph for discovery. |
|
This ticket/PR has been released with Hilla 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version. |
Support for
JsonNode
was added recently. This PR adds the same treatment for its subclasses.