feat: Flow main layout #2662
Merged
feat: Flow main layout #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename layout String to flowLayout boolean
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2662 +/- ##
==========================================
+ Coverage 92.21% 92.28% +0.07%
==========================================
Files 76 76
Lines 2466 2477 +11
Branches 639 643 +4
==========================================
+ Hits 2274 2286 +12
Misses 144 144
+ Partials 48 47 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
reviewed
Aug 20, 2024
Co-authored-by: Soroosh Taefi <[email protected]>
caalador
force-pushed
the
feat/flow-main-layout
branch
16 times, most recently
from
5a562b5 to
87cdbab
Compare
caalador
force-pushed
the
feat/flow-main-layout
branch
from
87cdbab to
ebac3be
Compare
taefi
requested changes
Aug 26, 2024
packages/ts/file-router/test/runtime/RouterConfigurationBuilder.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ts/file-router/src/runtime/RouterConfigurationBuilder.ts
Outdated
Show resolved
Hide resolved
taefi
requested changes
Aug 26, 2024
Co-authored-by: Soroosh Taefi <[email protected]>
|
|
This ticket/PR has been released with Hilla 24.5.0.alpha10 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
withLayoutsmethod to RouterConfigurationBuilderfor using Flow serverside view as main layout.
To enable call
.withLayouts(Flow)inroutes.tsxand add
"layout": trueinto the viewsViewConfig.