-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generator use only public getters and setters #2783
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 81 81
Lines 2677 2677
Branches 686 686
=======================================
Hits 2471 2471
Misses 156 156
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but let's also add an IT test for this use case to make sure that the runtime JSON is in sync with the generated TypeScript.
Isn't a unit test enough? No field in |
bfa128d
to
0b0d56b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks!
This ticket/PR has been released with Hilla 24.5.0.rc1 and is also targeting the upcoming stable 24.5.0 version. |
Fixes: #2587