Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generator use only public getters and setters #2783

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

krissvaa
Copy link
Contributor

@krissvaa krissvaa commented Oct 2, 2024

Fixes: #2587

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (aec4925) to head (a0cbcb8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2783   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          81       81           
  Lines        2677     2677           
  Branches      686      686           
=======================================
  Hits         2471     2471           
  Misses        156      156           
  Partials       50       50           
Flag Coverage Δ
unittests 92.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@platosha platosha self-requested a review October 2, 2024 13:48
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but let's also add an IT test for this use case to make sure that the runtime JSON is in sync with the generated TypeScript.

@cromoteca
Copy link
Contributor

cromoteca commented Oct 2, 2024

Looks good so far, but let's also add an IT test for this use case to make sure that the runtime JSON is in sync with the generated TypeScript.

Isn't a unit test enough? No field in openapi.json means no field in TS, that's for sure.

@krissvaa krissvaa force-pushed the fix/generator-get-set-only-public branch from bfa128d to 0b0d56b Compare October 7, 2024 11:57
Copy link

sonarqubecloud bot commented Oct 9, 2024

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@krissvaa krissvaa merged commit edf8c7e into main Oct 9, 2024
15 checks passed
@krissvaa krissvaa deleted the fix/generator-get-set-only-public branch October 9, 2024 12:16
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.rc1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protected setter/getter is in the generated typescript
4 participants