fix: regenerate file-router files when layouts changes #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
changed the title
mcollovati
changed the title
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 92.28% 92.28% -0.01%
==========================================
Files 81 81
Lines 2684 2683 -1
Branches 689 688 -1
==========================================
- Hits 2477 2476 -1
Misses 156 156
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Any suggestion on how to write at least test for this change? |
The layouts file can be updated by Flow at runtime when an annotated layout class is modified and reloaded. This change forces the Vite file-router plugin to regenerate files and trigger a fs-route-update to refresh the client configuration.
mcollovati
force-pushed
the
fix/fs_router_generate_runtime_file_on_layouts_change
branch
from
b56f53e to
a3e9411
Compare
|
platosha
approved these changes
Oct 14, 2024
platosha
deleted the
fix/fs_router_generate_runtime_file_on_layouts_change
branch
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
* fix: regenerate file-routes files when layouts change The layouts file can be updated by Flow at runtime when an annotated layout class is modified and reloaded. This change forces the Vite file-router plugin to regenerate files and trigger a fs-route-update to refresh the client configuration. * add tests * refactor test to reduce code duplication * remove unused import * rename test function * refactor tests * fix tests --------- Co-authored-by: Anton Platonov <[email protected]>
taefi
pushed a commit
that referenced
this pull request
Oct 14, 2024
…4.5) (#2832) fix: regenerate file-router files when layouts changes (#2796) * fix: regenerate file-routes files when layouts change The layouts file can be updated by Flow at runtime when an annotated layout class is modified and reloaded. This change forces the Vite file-router plugin to regenerate files and trigger a fs-route-update to refresh the client configuration. * add tests * refactor test to reduce code duplication * remove unused import * rename test function * refactor tests * fix tests --------- Co-authored-by: Marco Collovati <[email protected]> Co-authored-by: Anton Platonov <[email protected]>
|
This ticket/PR has been released with Hilla 24.6.0.alpha1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The layouts file can be updated by Flow at runtime when an annotated layout class is modified and reloaded.
This change forces the Vite file-router plugin to regenerate files and trigger a fs-route-update to refresh the client configuration.
Type of change
Checklist
Additional for
Featuretype of change