feat(full-stack signals): make operations thenable #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2799 +/- ##
==========================================
+ Coverage 92.60% 92.64% +0.03%
==========================================
Files 83 83
Lines 2812 2840 +28
Branches 724 728 +4
==========================================
+ Hits 2604 2631 +27
- Misses 156 157 +1
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
requested changes
Oct 16, 2024
taefi
requested changes
Oct 17, 2024
taefi
previously approved these changes
Oct 21, 2024
taefi
reviewed
Oct 21, 2024
|
Also ListSignal's operations need another follow-up PR to enable the thenables, right? |
taefi
reviewed
Oct 22, 2024
| @@ -65,19 +74,18 @@ export class ValueSignal<T> extends FullStackSignal<T> { | |||
| * | |||
| * @param callback - The function that is applied on the current value to | |||
| * produce the new value. | |||
| * @returns An operation subscription that can be canceled. | |||
| * @returns An operation object that allows to perform additional actions, including cancellation. | |||
There was a problem hiding this comment.
Suggested change
| * @returns An operation object that allows to perform additional actions, including cancellation. | |
| * @returns An operation object that allows to perform additional actions, | |
| * including cancellation. |
taefi
approved these changes
Oct 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a feature to make operations "thenable", which means it implements the ability for operations to return promise-like objects that can be chained. Those objects are in the
resultproperties to avoid the return type themselves to be treated as promises by lint checkers.Closes #2712