feat: enable ListSignal in generator-plugin-signals #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way updates are sent to the clients after the acceptance/rejection of an event on the server. With this applied, the REJECT event is removed and SNAPSHOT event containing the current state of the server-side signal only when (re)subscribing to a signal and not after each update. The events received by the server regarding each update to a signal is propagated to the clients with a boolean value that indicates the acceptance/rejection of the operation so clients decide to discard/apply/confirm the operation on their local value. This unifies the way with how List signals are going to work: to get snapshot events with the current state on the server only when subscribing signals (which can be a long list of values), and then getting updates of individual operations for subsequent updates, one at a time.
This extract the Signal abstraction out of ValueSignal so that the ListSignal implementation can inherit the common functionalities. Part of #2654
…ctor/extract-signal-abstraction
Also add some tests for ListSignal.ts
… taefi/feat/add-list-signal
This enables the generator-plugin-signals to correctly generate TS services for the endpoints with methods returning instances of ListSignal.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2810 +/- ##
==========================================
+ Coverage 92.56% 92.57% +0.01%
==========================================
Files 83 83
Lines 2798 2802 +4
Branches 720 721 +1
==========================================
+ Hits 2590 2594 +4
Misses 156 156
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
cromoteca
approved these changes
Oct 16, 2024
|
This ticket/PR has been released with Hilla 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the generator-plugin-signals to correctly generate TS services for the endpoints with methods returning instances of ListSignal.
Follow-up for #2775
Type of change
Checklist