Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant package names #2817

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

platosha
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.5@7f4f3f9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.5    #2817   +/-   ##
=======================================
  Coverage        ?   92.28%           
=======================================
  Files           ?       81           
  Lines           ?     2684           
  Branches        ?      689           
=======================================
  Hits            ?     2477           
  Misses          ?      156           
  Partials        ?       51           
Flag Coverage Δ
unittests 92.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@platosha platosha force-pushed the chore/no-package-names branch from 0be1d46 to 7c54af2 Compare October 11, 2024 14:45
taefi
taefi previously approved these changes Oct 11, 2024
@platosha platosha force-pushed the chore/no-package-names branch from 7c54af2 to a6f6d03 Compare October 11, 2024 15:38
@platosha platosha changed the base branch from main to 24.5 October 11, 2024 15:39
@platosha platosha changed the title chore: remove redundant package names chore: remove redundant package names (24.5) Oct 11, 2024
@platosha platosha changed the title chore: remove redundant package names (24.5) chore: remove redundant package names Oct 11, 2024
Copy link

@platosha platosha merged commit dafcc74 into 24.5 Oct 11, 2024
15 checks passed
@platosha platosha deleted the chore/no-package-names branch October 11, 2024 15:56
@vaadin-bot
Copy link
Collaborator

Hi @platosha and @platosha, when i performed cherry-pick to this commit to 1.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick dafcc74
error: could not apply dafcc74... chore: remove redundant package names (#2817)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @platosha and @platosha, when i performed cherry-pick to this commit to 2.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick dafcc74
error: could not apply dafcc74... chore: remove redundant package names (#2817)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

taefi added a commit that referenced this pull request Oct 14, 2024
chore: remove redundant package names (#2817)

Co-authored-by: Anton Platonov <[email protected]>
Co-authored-by: Soroosh Taefi <[email protected]>
platosha added a commit that referenced this pull request Oct 14, 2024
chore: remove redundant package names (#2817)

Co-authored-by: Anton Platonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants