fix: Check main layout presence separately (#2831)(CP: main)

[mshabarov]

Description

MenuRegistry::collectClientViews erases/overrides the layout entry by the view entry, if they have the same mapping, e.g. when you add @layout.tsx and @index.tsx in the same folder.

Thus, the ServerAndClientViewsProvider::hasMainMenu method may not get all the layouts in the input collection.

That leads to hasMainMenu=false and to skipping menu entries for Flow routes.

This patch uses vaadin/flow#20245 new method to detect top-level main layout that fulfils the same criteria: empty route, non-null children, no other root elements.

Related-to #2825

Type of change

• Bugfix
• Feature

Checklist

• I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
• I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• New and existing tests are passing locally with my change.
• I have performed self-review and corrected misspellings.

Additional for Feature type of change

• Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (d9ac5cf) to head (ba86b88).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2836   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          83       83           
  Lines        2771     2771           
  Branches      717      717           
=======================================
  Hits         2563     2563           
  Misses        156      156           
  Partials       52       52           

Flag	Coverage Δ
unittests	92.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[taefi]

LGTM.
There is only a consideration about using the already existing deploymentConfiguration instance in ServerAndClientViewsProvider instead of getting it from the VaadinService (from request). This is discussed with @mshabarov already, and since the original PR has been merged, this can also be merged, so that the subsequent PR fixing this can also be CPed automatically.

[vaadin-bot]

This ticket/PR has been released with Hilla 24.6.0.alpha1 and is also targeting the upcoming stable 24.6.0 version.