Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore vaadin field old invalid state (#2815) (CP: 24.5) #2857

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* Ignore vaadin field old invalid state
Fixes: #2341

* refactor: remove new elementValidity() API

* chore: fix linter error

---------

Co-authored-by: Anton Platonov <[email protected]>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.5@ab2297f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.5    #2857   +/-   ##
=======================================
  Coverage        ?   92.30%           
=======================================
  Files           ?       81           
  Lines           ?     2689           
  Branches        ?      689           
=======================================
  Hits            ?     2482           
  Misses          ?      156           
  Partials        ?       51           
Flag Coverage Δ
unittests 92.30% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@cromoteca cromoteca merged commit 3d096ab into 24.5 Oct 30, 2024
15 checks passed
@cromoteca cromoteca deleted the cherry-pick-2815-to-24.5-1729592990241 branch October 30, 2024 17:33
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Hilla 24.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants