fix: throw exception if feature flag is not enabled #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
==========================================
- Coverage 92.57% 92.57% -0.01%
==========================================
Files 85 85
Lines 3166 3164 -2
Branches 776 775 -1
==========================================
- Hits 2931 2929 -2
Misses 183 183
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This also removes the client-side check for the feature flag to let the UI being rendered normally, and server-side get a chance to handle the requests for subscribe or update. Fixes #2937
taefi
force-pushed
the
taefi/throw-if-featureflag-not-enabled
branch
from
af3de59 to
e68243e
Compare
cromoteca
requested changes
Dec 20, 2024
packages/java/endpoint/src/main/java/com/vaadin/hilla/signals/config/SignalsConfiguration.java
Outdated
Show resolved
Hide resolved
|
cromoteca
approved these changes
Dec 23, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
* fix: throw exception if feature flag is not enabled This also removes the client-side check for the feature flag to let the UI being rendered normally, and server-side get a chance to handle the requests for subscribe or update. Fixes #2937 * remove feature flag test * refine the import * apply changes from the review
taefi
added a commit
that referenced
this pull request
Dec 23, 2024
#3086) fix: throw exception if feature flag is not enabled (#2998) * fix: throw exception if feature flag is not enabled This also removes the client-side check for the feature flag to let the UI being rendered normally, and server-side get a chance to handle the requests for subscribe or update. Fixes #2937 * remove feature flag test * refine the import * apply changes from the review Co-authored-by: Soroosh Taefi <[email protected]>
|
This ticket/PR has been released with Hilla 24.7.0.alpha4 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This also removes the client-side check for
the feature flag to let the UI being rendered
normally, and server-side get a chance to
evaluate the feature-flag while handling the
requests for subscribe or update.
Fixes #2937
Type of change
Checklist