Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump preact #3023

Merged
merged 4 commits into from
Dec 17, 2024
Merged

chore: Bump preact #3023

merged 4 commits into from
Dec 17, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 17, 2024

No description provided.

Adds support for React 19 and fixes fast refresh issues
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (e6a93dc) to head (33e9e0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3023   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          85       85           
  Lines        3166     3166           
  Branches      776      776           
=======================================
  Hits         2931     2931           
  Misses        183      183           
  Partials       52       52           
Flag Coverage Δ
unittests 92.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur- Artur- requested a review from cromoteca December 17, 2024 11:32
@Artur- Artur- enabled auto-merge (squash) December 17, 2024 12:07
@Artur- Artur- merged commit 5eb904c into main Dec 17, 2024
15 checks passed
@Artur- Artur- deleted the bump-preact branch December 17, 2024 12:37
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @Artur-, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 5eb904c
error: could not apply 5eb904c... chore: Bump preact (#3023)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Artur- added a commit that referenced this pull request Dec 17, 2024
Adds support for React 19 and fixes fast refresh issues
cromoteca pushed a commit that referenced this pull request Dec 17, 2024
Adds support for React 19 and fixes fast refresh issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants