Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade vaadin-testbench to 9.3.8 #3173

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (933f5e5) to head (67f1c41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3173   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          85       85           
  Lines        3187     3187           
  Branches      778      778           
=======================================
  Hits         2953     2953           
  Misses        182      182           
  Partials       52       52           
Flag Coverage Δ
unittests 92.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cromoteca cromoteca enabled auto-merge (squash) January 24, 2025 08:40
@cromoteca cromoteca merged commit 854d42e into main Jan 24, 2025
15 checks passed
@cromoteca cromoteca deleted the update-vaadin-testbench-to-9.3.8-1737531553 branch January 24, 2025 08:52
vaadin-bot added a commit that referenced this pull request Jan 24, 2025
Co-authored-by: Zhe Sun <[email protected]>
Co-authored-by: Luciano Vernaschi <[email protected]>
@vaadin-bot
Copy link
Collaborator Author

Hi @vaadin-bot and @cromoteca, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 854d42e
error: could not apply 854d42e... chore: upgrade vaadin-testbench to 9.3.8 (#3173)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

cromoteca added a commit that referenced this pull request Jan 24, 2025
chore: upgrade vaadin-testbench to 9.3.8 (#3173)

Co-authored-by: Zhe Sun <[email protected]>
Co-authored-by: Luciano Vernaschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants