Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a dependency list to useGridDataProvider and useComboBoxDataProvider #3273

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Feb 21, 2025

This is to support using state in the fetch callback

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (f1dc8cb) to head (467b076).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3273      +/-   ##
==========================================
+ Coverage   86.97%   86.99%   +0.02%     
==========================================
  Files         118      118              
  Lines        8285     8292       +7     
  Branches     1267     1269       +2     
==========================================
+ Hits         7206     7214       +8     
  Misses       1064     1064              
+ Partials       15       14       -1     
Flag Coverage Δ
unittests 86.99% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur- Artur- force-pushed the grid-combobox-dependencies branch 3 times, most recently from 99d4d38 to ea7729a Compare February 22, 2025 12:11
This is to support using state and signals in the fetch callback
@Artur- Artur- force-pushed the grid-combobox-dependencies branch from ea7729a to 280ce2e Compare February 24, 2025 08:18
@Artur- Artur- marked this pull request as ready for review February 24, 2025 08:18
@Artur- Artur- requested review from taefi and Lodin and removed request for taefi February 24, 2025 08:18
Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Artur- Artur- merged commit 77b9667 into main Feb 24, 2025
15 checks passed
@Artur- Artur- deleted the grid-combobox-dependencies branch February 24, 2025 12:15
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.7.0.alpha15 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants