Skip to content

Commit

Permalink
fix: Disable dev mode gizmo to not use web-sockets (#43)
Browse files Browse the repository at this point in the history
* Revert "test: Swap the Push to long polling (#41)"

This reverts commit 578a529

* fix: Disable dev mode gizmo to not use web-sockets

* fix: Disable dev mode gizmo in the servlet init params
  • Loading branch information
mshabarov authored Oct 15, 2021
1 parent 578a529 commit 5242193
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
package com.vaadin.flow.quarkus.it;

import com.vaadin.flow.component.page.AppShellConfigurator;
import com.vaadin.flow.component.page.Push;
import com.vaadin.flow.shared.ui.Transport;
import com.vaadin.flow.theme.Theme;

@Theme("reusable-theme")
// TODO: Enable websockets when they are in use in Quarkus
@Push(transport = Transport.LONG_POLLING)
public class AppShellConfig implements AppShellConfigurator {
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
import com.vaadin.quarkus.QuarkusVaadinServlet;

@WebServlet(urlPatterns = "/*", name = "TestServlet", asyncSupported = true, initParams = {
@WebInitParam(name = "org.atmosphere.websocket.suppressJSR356", value = "true") })
@WebInitParam(name = "org.atmosphere.websocket.suppressJSR356", value = "true"),
// TODO: Enable dev mode gizmo when websockets are in use
@WebInitParam(name = "devmode.gizmo.enabled", value = "false")})
public class TestServlet extends QuarkusVaadinServlet {
// This servlet is here to give the suppressJSR356 parameter
// This servlet is here to give the suppressJSR356 parameter and disable
// dev mode gizmo which triggers unsupported web-sockets connection
}
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@
<failsafe-plugin.version>${surefire-plugin.version}</failsafe-plugin.version>
<maven.compiler.parameters>true</maven.compiler.parameters>

<vaadin.flow.version>8.0-SNAPSHOT</vaadin.flow.version>
<vaadin.flow.version>9.0-SNAPSHOT</vaadin.flow.version>
<quarkus.version>2.3.0.Final</quarkus.version>

<surefire-plugin.version>3.0.0-M5</surefire-plugin.version>
<surefire.excludedGroups>slow</surefire.excludedGroups>
</properties>

<repositories>
<!-- The order of definitions matters. Explicitly defining central
<!-- The order of definitions matters. Explicitly defining central
here to make sure it has the highest priority. -->
<repository>
<id>central</id>
Expand All @@ -61,7 +61,7 @@
</repositories>

<pluginRepositories>
<!-- The order of definitions matters. Explicitly defining central
<!-- The order of definitions matters. Explicitly defining central
here to make sure it has the highest priority. -->
<pluginRepository>
<id>central</id>
Expand Down

0 comments on commit 5242193

Please sign in to comment.