Skip to content

Commit

Permalink
chore: remove local-run profile (#62) (#64)
Browse files Browse the repository at this point in the history
Since flow base test class uses WebDriverManager to manage chromedriver
there's no need anymore to use driver-binary-downloader-maven-plugin
configured in local-run maven profile.

Closes #62
  • Loading branch information
mcollovati authored Feb 25, 2022
1 parent 8204b93 commit 6a3398b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 104 deletions.
34 changes: 0 additions & 34 deletions integration-tests/development/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -126,40 +126,6 @@
</build>

<profiles>
<profile>
<id>local-run</id>
<activation>
<property>
<name>!test.use.hub</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.lazerycode.selenium</groupId>
<artifactId>driver-binary-downloader-maven-plugin</artifactId>
<version>1.0.14</version>
<configuration>
<onlyGetDriversForHostOperatingSystem>true</onlyGetDriversForHostOperatingSystem>
<rootStandaloneServerDirectory>${project.basedir}/../driver
</rootStandaloneServerDirectory>
<downloadedZipFileDirectory>${project.basedir}/../driver_zips
</downloadedZipFileDirectory>
<customRepositoryMap>${project.basedir}/../drivers.xml</customRepositoryMap>
</configuration>
<executions>
<execution>
<phase>generate-test-resources</phase>
<goals>
<goal>selenium</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>java11</id>
<activation>
Expand Down
36 changes: 0 additions & 36 deletions integration-tests/drivers.xml

This file was deleted.

34 changes: 0 additions & 34 deletions integration-tests/production/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -126,40 +126,6 @@
</build>

<profiles>
<profile>
<id>local-run</id>
<activation>
<property>
<name>!test.use.hub</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.lazerycode.selenium</groupId>
<artifactId>driver-binary-downloader-maven-plugin</artifactId>
<version>1.0.14</version>
<configuration>
<onlyGetDriversForHostOperatingSystem>true</onlyGetDriversForHostOperatingSystem>
<rootStandaloneServerDirectory>${project.basedir}/../driver
</rootStandaloneServerDirectory>
<downloadedZipFileDirectory>${project.basedir}/../driver_zips
</downloadedZipFileDirectory>
<customRepositoryMap>${project.basedir}/../drivers.xml</customRepositoryMap>
</configuration>
<executions>
<execution>
<phase>generate-test-resources</phase>
<goals>
<goal>selenium</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>java11</id>
<activation>
Expand Down

0 comments on commit 6a3398b

Please sign in to comment.